Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace all Vue.set usages with direct assignment and spread operator (no-changelog) #6280

Merged
merged 7 commits into from
Jun 15, 2023
Merged

feat: Replace all Vue.set usages with direct assignment and spread operator (no-changelog) #6280

merged 7 commits into from
Jun 15, 2023

Conversation

alexgrozav
Copy link
Member

No description provided.

@alexgrozav alexgrozav changed the title refactor: replace all Vue.set usages with direct assignment and spread operator (no-changelog) feat: Replace all Vue.set usages with direct assignment and spread operator (no-changelog) May 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 8.47% and project coverage change: -0.19 ⚠️

Comparison is base (109442f) 28.41% compared to head (aac8176) 28.22%.

❗ Current head aac8176 differs from pull request most recent head 1c77347. Consider uploading reports for the commit 1c77347 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6280      +/-   ##
==========================================
- Coverage   28.41%   28.22%   -0.19%     
==========================================
  Files        2991     2983       -8     
  Lines      185588   185333     -255     
  Branches    20474    20329     -145     
==========================================
- Hits        52742    52318     -424     
- Misses     132054   132228     +174     
+ Partials      792      787       -5
Impacted Files Coverage Δ
...src/components/CredentialEdit/AuthTypeSelector.vue 0.00% <0.00%> (ø)
...src/components/CredentialEdit/CredentialConfig.vue 0.00% <0.00%> (ø)
...i/src/components/CredentialEdit/CredentialEdit.vue 0.00% <0.00%> (ø)
...kages/editor-ui/src/components/NodeDetailsView.vue 36.09% <0.00%> (ø)
packages/editor-ui/src/components/NodeSettings.vue 35.15% <0.00%> (-1.59%) ⬇️
...sLogStreaming/EventDestinationSettingsModal.ee.vue 0.00% <0.00%> (ø)
...ages/editor-ui/src/components/WorkflowSettings.vue 0.00% <0.00%> (ø)
packages/editor-ui/src/stores/credentials.store.ts 30.90% <0.00%> (-0.80%) ⬇️
packages/editor-ui/src/stores/nodeTypes.store.ts 40.81% <0.00%> (-0.31%) ⬇️
packages/editor-ui/src/stores/tags.store.ts 25.71% <0.00%> (-1.56%) ⬇️
... and 11 more

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 19, 2023
@cypress
Copy link

cypress bot commented May 19, 2023 •
edited
Loading

Passing run #1207 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 n8n-6270-replace-vueset-with-basic-value 🖥️ browsers:node18.12.0-chrome107 ?...
Project: n8n Commit: 1c77347590
Status: Passed Duration: 07:43 💡
Started: Jun 15, 2023 11:53 AM Ended: Jun 15, 2023 12:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@OlegIvaniv OlegIvaniv mentioned this pull request May 24, 2023
Merged
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 596cf07 into master Jun 15, 2023
@alexgrozav alexgrozav deleted the n8n-6270-replace-vueset-with-basic-value branch June 15, 2023 12:30
@janober
Copy link
Member

janober commented Jun 22, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgrozav @janober @cstuncsik